I looked through your changes, and you have definitely put in a good amount of work. Lots of good general cleanup in there along with the pull requests and bug fixes from you.
I didn't see anything that that stood out to me as anything that couldn't go into a 3.6 branch beyond the switch in Java support (and the name change, obviously ![]()
).
). It's a huge pain to have to try to cherry pick in the pieces that you merged and that would also lose the pull request connection and original author attribution which I like to preserve.
Therefore, I'm thinking the easiest route would be for me to create a new branch in liquibase where I can just merge in your changes directly as well as the 30ish outstanding commits from me not in your repo yet.
We won't be able to switch to Java 8, but I think Java 7 would be fine for a 3.6.0 release since you've done a lot of work around removing the generic parameters where they would not be needed in 7. I didn't see anything that would require 8 off hand, but the first step would be making sure it still compiles under Java7.
Once it compiles, I'll have to go through and undo the naming changes using search/replace which should be easy, then do a full check of the remaining changes to make sure none of them are introducing significantly breaking changes. Intellij's diff makes that not too terrible of a job, but it will take some time.
Once that is all done, I can merge back into master and we'll be good to go and can talk about what makes sense next.
What do you think?
Nathan