Hi,
i am just looking through the liquibase source to improve logging.
For that i extended SpringLiquibase to do some things better than the
standard bean. But i have an issue with that line in ChangeSet.java:
log.severe("Change Set " + toString(false) + "
failed. Error: " + e.getMessage(), e);
The logging message itself is nice and i can nicely put that into
my own log file via log4j.xml. But appending the exception to the
logging results in a StackTrace in the log which distracts from the
"important" liquibase informations. No one cares about the
stack at this point. All matters is what the liquibase issue is and
this is logged perfectly.
A few lines above, we have this line, which is how it should be
elsewhere too:
log.info("Change set " + toString(false) + " failed,
but failOnError was false. Error: " + e.getMessage());
So can anybody with commit rights fix this? Would be very nice. IMO
the first line is a bad practice when it comes to logging.
